[UPDATE] ZScriptification, A through M
- Ghastly
- Topic Author
- Administrator
- Posts: 33
Apotheosis:
Added SXF_TRANSFERPOINTERS to the BoltShooter actor, so kills are properly credited to the player who fired the weapon. Also had to remove the ~ from the name of the powered version in the ZScript version.
BFG10K:
Removed a reference to an obituary string in the bulletpuff actor with no corresponding Language lump. It was unnecessary anyway because the weapon already had an obituary.
Blood Scepter:
Streamlined the monster death state in the Decorate and ZScript version. Had to remove the ~ from the name of the powered version in the ZScript version.
Cult Staff:
I'm pretty sure "Random(1,-1)*frandom(0," was supposed to be in the Pitch parameter and not in Flags parameter, in CultShot2 and 3. Fixed it, and added CMF_TRACKOWNER so it properly tracks kills. Also, changed the FRandom damage parameter to Random because Damage is in integers.
Frost Fang:
Ammo no longer replaces BlasterAmmo (doesn't really matter, but still).
Grenade Launcher (KDiZD):
Marked the projectile trail client side.
Grenade Launcher:
Commented out the +ExplodeOnDeath flag, since it seems to have to do with Skulltag medals and it gives a warning that it's deprecated.
Karasawa:
Added the NoDelay state property to the projectile's first state so the "fly" sound plays properly, and fixed the SNDINFO so it actually uses it right (checked IGPack to make sure).
Lightbringer:
Removed the ~ from the powered weapon's name, and fixed a broken dynamic light.
https://www.dropbox.com/s/muaqy04pk3lbz60/ZScriptification-Armory-AthroughM.zip?dl=0
Please Log in or Create an account to join the conversation.
- Blue Shadow
- Administrator
- Posts: 1129
- The test monster replaces the original monster. It shouldn't do that.
- Very minor: there are references in the comments to the altfire mode. To avoid confusion, these should be changed to refer to the powered mode.
- Have you thought about using event handlers to handle the health steal ability instead of handling it by injecting code into monsters' code? This way it'd work out-of-the-box (I can help you with this if you'd like).
CultStaff
- Line 60: deprecation warning about A_FireCustomMissile.
- Line 140: the state is missing the "Bright" keyword.
Flamethrower
- Lines 24 and 27: missing semi-colon at the end of the lines.
FrostFang
- Lines 45 and 85: deprecation warning about A_FireCustomMissile.
- Line 113: deprecation warning about VelX, VelY and VelZ.
- Lines 41, 42, 43, 44, 80, 81, 82, 83 and 143: floating point truncation warning
Please Log in or Create an account to join the conversation.
- Ghastly
- Topic Author
- Administrator
- Posts: 33
I thought about it, but I couldn't see a way on the wiki to restrict it to the Blood Scepter with the WorldThingDied event.Blue Shadow wrote: Have you thought about using event handlers to handle the health steal ability instead of handling it by injecting code into monsters' code? This way it'd work out-of-the-box (I can help you with this if you'd like).
Please Log in or Create an account to join the conversation.
- Blue Shadow
- Administrator
- Posts: 1129
Please Log in or Create an account to join the conversation.
- Blue Shadow
- Administrator
- Posts: 1129
Please Log in or Create an account to join the conversation.
- Blue Shadow
- Administrator
- Posts: 1129
A couple of notes regarding the Blood Scepter and Frost Fang:
Blood Scepter
- I've gone with my idea of using an event handler for the health steal ability.
Frost Fang
- Replaced Random() with FRandom() to resolve the floating point truncation warnings. This means it now behaves as was intended, as opposed to how it actually behaved.
Please Log in or Create an account to join the conversation.