header general

[Update] Bubble Boiling

  • MagicWazard
  • MagicWazard's Avatar Topic Author
  • Moderator
  • Moderator
More
9 years 11 months ago #1 by MagicWazard
[Update] Bubble Boiling was created by MagicWazard
Download:
https://www.dropbox.com/s/zigrv12ga8hphuo/BubbleBoiling.zip?dl=0

I was using this in a map earlier today, and I noticed that the lava bubble spawner wasn't properly making use of the arg to disable sound; the check to play sound was in the very first state of the spawner, and thus was being skipped, causing sound to always play. I'm submitting a quick update with a fix that allows the lava bubble spawner to have its sound disabled. The rest of the spawners appear to work correctly, and I haven't made any other changes (not even to the odd state label names used by some of the particles).

Warning: Spoiler!

Please Log in or Create an account to join the conversation.

  • Tormentor667
  • Tormentor667's Avatar
  • Founder
  • Founder
More
9 years 11 months ago #2 by Tormentor667
Replied by Tormentor667 on topic [Update] Bubble Boiling
Works :)

Please Log in or Create an account to join the conversation.

  • Blue Shadow
  • Blue Shadow's Avatar
  • Administrator
  • Administrator
More
9 years 11 months ago #3 by Blue Shadow
Replied by Blue Shadow on topic [Update] Bubble Boiling

MagicWazard wrote: I was considering adding "NoDelay" to the beginning of each state, but if somebody hasn't updated their ZDoom in a while, then it'll cause problems.

The NoDelay state flag has been there since 2.7.0 (which was released in mid 2013). So it has been in two official releases so far. I don't see using it as problem here (okay, maybe it is for Zandronum people!).

Please Log in or Create an account to join the conversation.

  • MagicWazard
  • MagicWazard's Avatar Topic Author
  • Moderator
  • Moderator
More
9 years 11 months ago #4 by MagicWazard
Replied by MagicWazard on topic [Update] Bubble Boiling

Blue Shadow wrote: The NoDelay state flag has been there since 2.7.0 (which was released in mid 2013). So it has been in two official releases so far. I don't see using it as problem here (okay, maybe it is for Zandronum people!).

2.7.1 , according to the wiki (though there's only a months difference between the two releases, so it's practically moot). Either way, my main concern is that I'm just submitting a bug fix, and didn't get permission to optimize or anything like that, so I'd rather not open that can of worms at the moment. :fear:

Warning: Spoiler!

Please Log in or Create an account to join the conversation.

  • Gez
  • Gez's Avatar
  • Administrator
  • Administrator
More
9 years 11 months ago #5 by Gez
Replied by Gez on topic [Update] Bubble Boiling
The "new" template points to the latest version, and since there was only one month I hadn't removed it from 2.7.0's new features... So plenty of stuff say "2.7.1" when really it's 2.7.0.

It doesn't bother me too much because there's an incompatibility between 2.7.0 and 2.7.1 so people should be encouraged to use 2.7.1 instead of 2.7.0.

Please Log in or Create an account to join the conversation.

  • MagicWazard
  • MagicWazard's Avatar Topic Author
  • Moderator
  • Moderator
More
9 years 11 months ago #6 by MagicWazard
Replied by MagicWazard on topic [Update] Bubble Boiling
So, do you think that replacing the extra "TNT1 A 0" states with the "NoDelay" flag is a small enough change that I could go ahead and put it in without having to get the original submitter's approval? I do think it would be good practice to encourage this type of usage going forward; and, upon looking back, I realize that the flag's been present for nearly a year-and-a-half now (time flies! for realsies!), so the burden of outdated engine really falls more on the user than the submission.

Please Log in or Create an account to join the conversation.

  • Blue Shadow
  • Blue Shadow's Avatar
  • Administrator
  • Administrator
More
9 years 11 months ago #7 by Blue Shadow
Replied by Blue Shadow on topic [Update] Bubble Boiling
I'd say keep it as is for this one. One extra line in the Spawn state is not going to hurt...

Please Log in or Create an account to join the conversation.

  • Blue Shadow
  • Blue Shadow's Avatar
  • Administrator
  • Administrator
More
9 years 11 months ago #8 by Blue Shadow
Replied by Blue Shadow on topic [Update] Bubble Boiling

Please Log in or Create an account to join the conversation.